Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clone functionality. #106

Closed
wants to merge 1 commit into from
Closed

Add clone functionality. #106

wants to merge 1 commit into from

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Nov 26, 2018

This patch add support for cloning functionality
in glusterfs CSI driver when volumesource is filled
in the request.

Fix: #100

Signed-off-by: Madhu Rajanna [email protected]
Signed-off-by: Humble Chirammal [email protected]

Describe what this PR does
Provide some context for the reviewer

Is there anything that requires special attention?
Do you have any questions? Did you do something clever?

Related issues:
Mention any github issues relevant to this PR

This patch add support for cloning functionality
in glusterfs CSI driver when volumesource is filled
in the request.

Fix: gluster#100

Signed-off-by: Madhu Rajanna <[email protected]>
Signed-off-by: Humble Chirammal <[email protected]>
@ghost ghost assigned humblec Nov 26, 2018
@ghost ghost added the in progress label Nov 26, 2018
@humblec
Copy link
Contributor Author

humblec commented Nov 26, 2018

The CSI test is missing this capability and causing this build to fail. I have sent a PR to resolve this issue. kubernetes-csi/csi-test#145

@humblec
Copy link
Contributor Author

humblec commented Dec 6, 2018

@Madhu-1 The above mentioned PR is merged!..

@Madhu-1
Copy link
Member

Madhu-1 commented Dec 6, 2018

retest this please

@Madhu-1 Madhu-1 added the DO-NOT-MERGE Do not merge label Dec 6, 2018
@Madhu-1
Copy link
Member

Madhu-1 commented Dec 6, 2018

@humblec Added do not merge label, we need to wait for clone functionality implementation in sidecar container

@humblec
Copy link
Contributor Author

humblec commented Dec 6, 2018

@Madhu-1 Agreed.. Lets wait some more.

@joejulian joejulian closed this Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add efficient volume cloning support
3 participants