Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable Scene Builder to load FXML with unresolved imports (#120, #281, #733) #576

Open
wants to merge 48 commits into
base: master
Choose a base branch
from
Open

fix: enable Scene Builder to load FXML with unresolved imports (#120, #281, #733) #576

wants to merge 48 commits into from

Commits on Oct 3, 2022

  1. fix: Allows Scene Builder conditionally to load FXML files with 

    unresolved imports.

There is also a new option (preserve unresolved imports) which also
allows to keep the imports in saved FXML files.
    @Oliver-Loeffler
    Oliver-Loeffler committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    85723a2 View commit details
    Browse the repository at this point in the history

  2. Renamed the preference 'keep unresolved imports' into 'allow loading … 

    …of FXML with unresolved imports' as it exactly does the 2nd.
    @Oliver-Loeffler
    Oliver-Loeffler committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    6d11253 View commit details
    Browse the repository at this point in the history

  3. Merged with Scene Builder baseline.

    @Oliver-Loeffler
    Oliver-Loeffler committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    c5880b4 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2022

  1. Merge branch 'gluonhq:master' into issue-120

    @Oliver-Loeffler
    Oliver-Loeffler authored Nov 1, 2022
    Configuration menu
    Copy the full SHA
    acf8460 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2023

  1. Merge branch 'gluonhq:master' into issue-120

    @Oliver-Loeffler
    Oliver-Loeffler authored Apr 6, 2023
    Configuration menu
    Copy the full SHA
    ca92d54 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Merge branch 'gluonhq:master' into issue-120

    @Oliver-Loeffler
    Oliver-Loeffler authored Mar 18, 2024
    Configuration menu
    Copy the full SHA
    1d60439 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. Merge branch 'gluonhq:master' into issue-120

    @Oliver-Loeffler
    Oliver-Loeffler authored Mar 27, 2024
    Configuration menu
    Copy the full SHA
    d3f473f View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Merge branch 'gluonhq:master' into issue-120

    @Oliver-Loeffler
    Oliver-Loeffler authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    d04fef7 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. Added test to proof that FXOMDocument can load files despite having u… 

    …nresolvable types declared as import.
    @Oliver-Loeffler
    Oliver-Loeffler committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    cbdfd05 View commit details
    Browse the repository at this point in the history

  2. Added failing test for FXOMSaver.

    @Oliver-Loeffler
    Oliver-Loeffler committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    0e05916 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Opening, Saving and Save as are working. Also basic editing such as d… 

    …eleting elements. Element browsing is not working.
    @Oliver-Loeffler
    Oliver-Loeffler committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    09ed1d0 View commit details
    Browse the repository at this point in the history

  2. Editing incl. component browsing works as intended.

    @Oliver-Loeffler
    Oliver-Loeffler committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    fe33457 View commit details
    Browse the repository at this point in the history

  3. Added content to the FXOMSaverTest.

    @Oliver-Loeffler
    Oliver-Loeffler committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    efe34c4 View commit details
    Browse the repository at this point in the history

  4. Updated license header.

    @Oliver-Loeffler
    Oliver-Loeffler committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    c05ceb6 View commit details
    Browse the repository at this point in the history

  5. Increased log level from FINE to INFO so that file open actions can b… 

    …e reviewed and identified.
    @Oliver-Loeffler
    Oliver-Loeffler committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    1a56caa View commit details
    Browse the repository at this point in the history

  6. Reworked FXOMRefresher to avoid the detection of unknown imports via … 

    …repeated exceptions.
    @Oliver-Loeffler
    Oliver-Loeffler committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    076ea9d View commit details
    Browse the repository at this point in the history

  7. Added failing test.

    @Oliver-Loeffler
    Oliver-Loeffler committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    515a84e View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. Removed log statements.

    @Oliver-Loeffler
    Oliver-Loeffler committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    908b838 View commit details
    Browse the repository at this point in the history

  2. Added missing break statement in switch expression. Formatting.

    @Oliver-Loeffler
    Oliver-Loeffler committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    c74849f View commit details
    Browse the repository at this point in the history

  3. Updated year in header

    @Oliver-Loeffler
    Oliver-Loeffler committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    1de1e31 View commit details
    Browse the repository at this point in the history

  4. Formatting and license header.

    @Oliver-Loeffler
    Oliver-Loeffler committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    a814fc9 View commit details
    Browse the repository at this point in the history

  5. Updated license header.

    @Oliver-Loeffler
    Oliver-Loeffler committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    2f52ccb View commit details
    Browse the repository at this point in the history

  6. Updated license header.

    @Oliver-Loeffler
    Oliver-Loeffler committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    edd76d9 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Added test for FXOMImportsRemover and replacement/removal mechanism.

    @Oliver-Loeffler
    Oliver-Loeffler committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    095dc11 View commit details
    Browse the repository at this point in the history

  2. Formatting.

    @Oliver-Loeffler
    Oliver-Loeffler committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    346a493 View commit details
    Browse the repository at this point in the history

  3. Simplified FXOMSaver handling of unresolvable imports.

    @Oliver-Loeffler
    Oliver-Loeffler committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    528b765 View commit details
    Browse the repository at this point in the history

  4. Removed modification of GlueInstruction (toString()).

    @Oliver-Loeffler
    Oliver-Loeffler committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    953de94 View commit details
    Browse the repository at this point in the history

  5. Updated expectations/asserts of wildcard import test for FXOMSaver.

    @Oliver-Loeffler
    Oliver-Loeffler committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    e599bb4 View commit details
    Browse the repository at this point in the history

  6. Formatting.

    @Oliver-Loeffler
    Oliver-Loeffler committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    93089b9 View commit details
    Browse the repository at this point in the history

  7. Organized imports.

    @Oliver-Loeffler
    Oliver-Loeffler committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    5847ac1 View commit details
    Browse the repository at this point in the history

  8. Complex condition moved into separate method.

    @Oliver-Loeffler
    Oliver-Loeffler committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    19028d6 View commit details
    Browse the repository at this point in the history

  9. Extracted error handling logic into separate methods.

    @Oliver-Loeffler
    Oliver-Loeffler committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    7621fb6 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Added user notifiction in app to indicate missing types / unresolvabl… 

    …e imports to the user.
    @Oliver-Loeffler
    Oliver-Loeffler committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    d9dd99a View commit details
    Browse the repository at this point in the history

  2. Reworked dialog title to show file name.

    @Oliver-Loeffler
    Oliver-Loeffler committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    4a7f937 View commit details
    Browse the repository at this point in the history

  3. Formatting

    @Oliver-Loeffler
    Oliver-Loeffler committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    0c5b3ef View commit details
    Browse the repository at this point in the history

  4. Corrected typo.

    @Oliver-Loeffler
    Oliver-Loeffler committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    ac79601 View commit details
    Browse the repository at this point in the history

  5. The missing types notification is now shown per editor window, not as… 

    … a general message for all.
    @Oliver-Loeffler
    Oliver-Loeffler committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    8e18795 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Merge branch 'gluonhq:master' into issue-120

    @Oliver-Loeffler
    Oliver-Loeffler authored Aug 26, 2024
    Configuration menu
    Copy the full SHA
    690765d View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2024

  1. Merge branch 'gluonhq:master' into issue-120

    @Oliver-Loeffler
    Oliver-Loeffler authored Sep 29, 2024
    Configuration menu
    Copy the full SHA
    55f95ab View commit details
    Browse the repository at this point in the history

  2. Updated Surefire version to eliminate JPMS related errors during test.

    @Oliver-Loeffler
    Oliver-Loeffler committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    cb6e16e View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Merge branch 'master' into issue-120

    @Oliver-Loeffler
    Oliver-Loeffler authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    eed9eb8 View commit details
    Browse the repository at this point in the history

  2. Removed duplicate logger instance.

    @Oliver-Loeffler
    Oliver-Loeffler committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    73dddef View commit details
    Browse the repository at this point in the history

  3. Added missing dialog title.

    @Oliver-Loeffler
    Oliver-Loeffler committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    a4723e9 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Merge branch 'gluonhq:master' into issue-120

    @Oliver-Loeffler
    Oliver-Loeffler authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    2cdcd66 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'gluonhq:master' into issue-120

    @Oliver-Loeffler
    Oliver-Loeffler authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    00566d5 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Merge branch 'gluonhq:master' into issue-120

    @Oliver-Loeffler
    Oliver-Loeffler authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    ae88732 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Merge branch 'master' into issue-120

    @jperedadnr
    jperedadnr authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    8094085 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2024

  1. Merge branch 'gluonhq:master' into issue-120

    @Oliver-Loeffler
    Oliver-Loeffler authored Nov 10, 2024
    Configuration menu
    Copy the full SHA
    2cbaffc View commit details
    Browse the repository at this point in the history