Document and check WCS usage for to_sky option in subset-to-region translator; add tests

[cshanahan1]

Closing https://github.com/glue-viz/glue-astronomy/pull/96/files as the workaround in there can go directly in Jdaviz, but keeping changes to docstring/tests for the roi_subset_state_to_region function. Not including a change log entry for this.

[pllim]

Much cleaner now. Thanks!

@dhomeier would need to enable the CI and do a final review.

[dhomeier]

Thanks, looks great, tests just were not run due to some codestyle failures.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e895db9) 96.90% compared to head (aa305d7) 96.68%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
- Coverage   96.90%   96.68%   -0.22%     
==========================================
  Files          18       18              
  Lines        1421     1448      +27     
==========================================
+ Hits         1377     1400      +23     
- Misses         44       48       +4     

Files	Coverage Δ
glue_astronomy/translators/regions.py	92.25% <100.00%> (+0.10%)	⬆️
glue_astronomy/translators/tests/test_regions.py	99.39% <100.00%> (+0.05%)	⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dhomeier]

@pllim do you know if a spectral_cube release with your fix is planned, or should we move that to dev-deps at least for now, to unbreak astropy-dev?

[pllim]

spectral-cube release is up to @keflavich or @astrofrog , I think?

[keflavich]

@e-koch might also be able to help, but we're probably not issuing a release before Oct 25

[pllim]

Maybe it is time to seriously think about:

• Make spectral-cube optional dependency #62

[dhomeier]

Having run into the same radio-beam trap now, I tend to agree.

[e-koch]

@dhomeier does radio-beam also just need a new release? Or is there another issue?

[dhomeier]

Having all imported in sync from the dev branches in #98 resolves the issue now; it's probably more problematic for downstream packages that are not explicitly testing spectral_cube and deps.

[keflavich]

we pushed a new release. If either of you would like to join on as maintainers to help with the release cycle, let us know.

[dhomeier]

we pushed a new release. If either of you would like to join on as maintainers to help with the release cycle, let us know.

Thanks, re-running the tests with the updates fixed everything!

I know virtually nothing about radio-beam, but would be interested in staying up to date with spectral-cube-specutils integration.

[e-koch]

Thanks, @dhomeier -- radio-beam is quite lightweight, and helping with just the release cycle would very likely keep it from being an issue in the future. The codebase is quite stable at this point.