Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: verify if document exists #182

Closed

Conversation

gabrielzevedo
Copy link

Fix this error: #181

@glromeo
Copy link
Owner

glromeo commented Jun 11, 2024

I don't think your fix makes sense...have you actually tested it?
The point in which you check for document to be defined is within
the esbuild process...that's not where you want to do it
If anything one should provide a lazy load implementation that hydrates
the style module but I don't fully understand if this is a SSR issue and
I don't have anyway the capacity to ensure SSR coverage therefore I am inclined not
to change style modules for the moment

@glromeo glromeo closed this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants