feat: add support for type: 'local-css'
#173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kohlmannj
changed the title
type: ‘local-css’type: 'local-css'
|
Gently nudging this one! Thanks and no worries, just wanted to make contact 🙇🏼♂️ |
|
sorry... just got back from my trip I'll have a look tonight
…On Wed, 6 Mar 2024, 15:51 kohlmannj, ***@***.***> wrote:
Gently nudging this one! Thanks and no worries, just wanted to make
contact 🙇🏼♂️
—
Reply to this email directly, view it on GitHub
<#173 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABHJVJFNK2AKHYEVKM2L23YW43R3AVCNFSM6AAAAABEAWPP52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBRGE4DOOBWGU>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Ah, no worries, @glromeo, I didn't know! Please take your time, and thanks again ✨ |
|
This is the most professional contribution I've seen so far... A very big thank you for it! |
|
@glromeo My turn for a delayed reply 😅 🤦🏼♂️ You are very welcome! Glad to contribute 🙇🏼♂️ ✨ |
|
Oh, at your leisure, a new release with this feature would be much appreciated 😊 Once again, no rush! Thanks @glromeo! |
|
Yup, I wanted to see if I can fix some of these outstanding issues together
with it but Indeed I rather not keep it waiting
…On Tue, 12 Mar 2024, 17:58 kohlmannj, ***@***.***> wrote:
Oh, at your leisure, a new release with this feature would be much
appreciated 😊 Once again, no rush! Thanks @glromeo
<https://github.com/glromeo>!
—
Reply to this email directly, view it on GitHub
<#173 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABHJVN7AN4EY3FKMA3V243YX465DAVCNFSM6AAAAABEAWPP52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJSGI2DMMRXGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Ah, no worries. Really appreciate the release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings!
I've been experimenting with esbuild and esbuild-plugin-sass, and I wanted a way to compile "Sass module" files (
*.module.scss) then leverage esbuild's built-in CSS processing features, as opposed to using PostCSS andpostcss-modules.I think I've got just that here in this PR:
The plugin's
typeoption now accepts the string'local-css'. This is very similar totype: 'css'in that, when usingtype: 'local-css', the plugin simply compiles the Sass file and then passes the rest off to esbuild with the appropriate loader specified (i.e.type: 'local-css'→ use the local-css loader).I've also updated the README, added a new fixture project
test/fixture/local-css/and a new e2e unit test.Cheers,
Joe