Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging Nathan's async changes #163

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Conversation

glromeo
Copy link
Owner

@glromeo glromeo commented Jan 30, 2024

No description provided.

@NathanBeddoeWebDev
Copy link

Thanks. I've removed the naming changes, and confirmed with benchmark that the performance boost is still there. I'll have to check what I did in my fork branch to cook it that bad.

@glromeo
Copy link
Owner Author

glromeo commented Jan 30, 2024

the init compiler was in the render

@glromeo glromeo merged commit bd779d8 into glromeo:main Jan 30, 2024
1 check failed
@glromeo
Copy link
Owner Author

glromeo commented Jan 30, 2024

now I am going to fix the tests and release another version

@glromeo
Copy link
Owner Author

glromeo commented Jan 30, 2024

@NathanBeddoeWebDev

image

the compiler needs to be disposed at the end...that's why the tests where hanging

@glromeo
Copy link
Owner Author

glromeo commented Jan 30, 2024

@NathanBeddoeWebDev I am sorry that by making the PR myself you don't show up amongst the contributors
if you want just create a PR for something silly like removing that semicolon at line 78
or I think I saw an unused import somewhere ...I will be glad to merge it 😆

@NathanBeddoeWebDev
Copy link

Haha, all good. I'm not a massive open sourcer so I don't really mind. Sass performance has just been something of a quest for me at work for the past year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants