-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added sass-embedded and swapped to async compiler api #162
Conversation
Thank you Nathan my old branch does when running it in your branch it does Now... I am pleasantly surpised by the initial build speed improvement 😮 and puzzled 🤔 by the For TS changes it's pretty much the same and that makes sense but sass...hmm I am eager to merge your PR let me get my head around this first, ideally I want to merge once and have Good job man!!! 👍 |
there must have been something going on earlier on because now I get more consistent results built in: 816.274ms built in: 181.181ms |
Yup... I am impressed man! |
Is coverage failing? Not sure why that'd be, but I'm seeing test results, and then it's hanging instead of showing me test coverage results. |
😆 this is not the branch I was benchmarking with |
good news tests are failing (here) mostly because of the embedded using \r in windows... |
can you please create another PR from main? |
See discussion @ #160
Also see sass/sass#3296 for background into this issue, and links to proposals and PR's.