fix: use correct sourcemap line numbers with css-text and lit-css #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! Thanks for this awesome plugin 😄
We noticed an issue where our sourcemaps were broken when using
type: 'css-text'and the sources would be pointed to the previous line. When adding the same sass to our global stylesheets everything worked as expected, upon reading the source I noticed the plugin would add a leading newline to modules that usecss-text. When removing that leading new line our sourcemaps now work as expected, which makes sense as the transformed output currently has a leading newline which isn't represented in the sourcemap.While I was there, I also applied the same fix to
lit-css.