Allow validating only unsolved ITIL #18604
Conversation
|
Once a ticket has been resolved, requests can no longer be modified, but once it has been closed, they can be edited again. |
cconard96
force-pushed
the
fix/validate_not_solved
branch
from
e2ea753 to
3beb5c4
Compare
|
I cannot recreate that. I added an approval to myself while the ticket was unsolved and the answer form was shown. I solved the ticket and the answer form disappeared. I closed the ticket and the answer form remained gone. |
|
Should not this one targets 10.0 branch? |
I didn't think so. Less of a bug and more changing a long-standing behavior. I felt better not introducing a behavior change, especially a restriction, in 10.0. |
OK for me |
There was a problem hiding this comment.
Technically OK, but I would prefer to have a functional validation from @orthagh before merging this one.
|
Seems OK for me, at first I thought I had the same issue as shown in @Lainow's comment but in fact it is the solution approval form which is being displayed in this case, not the validation one.
Unrelated but display of the solution is a bit weird tho (I'll open an issue) |
Checklist before requesting a review
Description
While working on #17215, I noticed one place where the search result link for tickets waiting for approval filtered to unsolved tickets only. Some of the issue reported in the bug report was fixed in #18380 but there was still an inconsistency. Instead of hiding the ability to validate closed tickets only, it seems like it makes sense to also block validating solved tickets and changes. Once something is solved, all actions should be considered finished so approvals are expected to happen before that. Once solved, it is just waiting for user validation that the fix worked or validation from technicians in the case of an Observed change.