Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple strategies to be defined at once for certain destination fields #18574

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ccailly
Copy link
Member

@ccailly ccailly commented Dec 18, 2024

Checklist before requesting a review

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

Added the possibility of combining several strategies for certain fields in form destinations.
Modification of the UI/UX of the “Associated Items” field:

  • More compact interface in the form of a single component
  • Removal of the “Add new item” button for an automatic new item system as soon as all previous fields have been completed.

Screenshots (if appropriate):

image

@ccailly ccailly self-assigned this Dec 19, 2024
@ccailly ccailly added the Forms label Dec 19, 2024
@ccailly ccailly added this to the 11.0.0 milestone Dec 19, 2024
@ccailly ccailly marked this pull request as ready for review December 19, 2024 08:45
@AdrienClairembault
Copy link
Contributor

image

Not sure the word "strategy" should be shown to users, it feels too technical IMO.

@AdrienClairembault
Copy link
Contributor

@orthagh We'll have to take a look at this and see how we can make this config page "simpler" because there are a lot of options right now and it feels overwhelming.

@ccailly ccailly force-pushed the feature/form-destinations-multiple-configs branch from b757e5e to 6c69bd8 Compare January 6, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants