Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Fix) Visibility of private task assign to me #17918

Merged

Conversation

Lainow
Copy link
Contributor

@Lainow Lainow commented Sep 24, 2024

Checklist before requesting a review

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

  • It fixes !34489

I can see a private spot that has been assigned to me even though I don't have the right to see private spots.
Added the right to view my group's tasks.

Screenshots (if appropriate):

@Lainow Lainow marked this pull request as ready for review September 24, 2024 13:16
@Lainow Lainow self-assigned this Sep 24, 2024
@Lainow Lainow changed the title Can see private task assign to me or my group Can see private task assign to me Sep 24, 2024
@Lainow Lainow changed the title Can see private task assign to me (Fix) Visibility of private task assign to me Sep 24, 2024
src/CommonITILObject.php Show resolved Hide resolved
phpunit/functional/TicketTest.php Outdated Show resolved Hide resolved
phpunit/functional/TicketTest.php Outdated Show resolved Hide resolved
@Lainow Lainow force-pushed the fix-private-task-visibility branch from d59701c to 101f162 Compare September 26, 2024 14:28
phpunit/functional/TicketTest.php Outdated Show resolved Hide resolved
phpunit/functional/TicketTest.php Outdated Show resolved Hide resolved
phpunit/functional/TicketTest.php Outdated Show resolved Hide resolved
phpunit/functional/TicketTest.php Outdated Show resolved Hide resolved
phpunit/functional/TicketTest.php Outdated Show resolved Hide resolved
@cedric-anne cedric-anne added this to the 10.0.17 milestone Sep 30, 2024
@cedric-anne cedric-anne merged commit f3bcbf2 into glpi-project:10.0/bugfixes Sep 30, 2024
6 checks passed
@alisher372
Copy link

alisher372 commented Oct 11, 2024

whats about assigned group to the private task?

@glpi-project glpi-project locked and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants