Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix display of fields with full_width enabled #17916

Merged
merged 3 commits into from
Sep 30, 2024
Merged

fix display of fields with full_width enabled #17916

merged 3 commits into from
Sep 30, 2024

Conversation

orthagh
Copy link
Contributor

@orthagh orthagh commented Sep 24, 2024

Checklist before requesting a review

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

    -> Probably not

Description

Correct the label / input ratio for fields with full_width: true

Screenshots (if appropriate):

Before
image

After
image

orthagh
orthagh commented Sep 24, 2024
View reviewed changes
css/includes/_base.scss Outdated Show resolved Hide resolved
@trasher
Copy link
Contributor

trasher commented Sep 30, 2024

Please rebase to solve conflicts

@orthagh
Copy link
Contributor Author

orthagh commented Sep 30, 2024

done

@cedric-anne cedric-anne merged commit c38ea1a into glpi-project:main Sep 30, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdrienClairembault AdrienClairembault AdrienClairembault approved these changes

@cconard96 cconard96 cconard96 approved these changes

@trasher trasher trasher approved these changes

@cedric-anne cedric-anne Awaiting requested review from cedric-anne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@orthagh @trasher @cconard96 @AdrienClairembault @cedric-anne