Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(Approval) Twig Update #17900

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Feat(Approval) Twig Update #17900

merged 2 commits into from
Sep 25, 2024

Conversation

Lainow
Copy link
Contributor

@Lainow Lainow commented Sep 19, 2024 •
edited
Loading

Checklist before requesting a review

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

  • Switch the ITIL object approval page to TWIG (necessary for the ITIL object print preview to function correctly).

Screenshots (if appropriate):

Before
image

After
image

@Lainow Lainow force-pushed the twig-update-approvaltab branch from c59c7c8 to 8372edb Compare September 19, 2024 13:36
@Lainow Lainow marked this pull request as ready for review September 19, 2024 13:53
@Lainow Lainow self-assigned this Sep 19, 2024
cconard96
cconard96 suggested changes Sep 23, 2024
View reviewed changes
src/CommonITILValidation.php Outdated Show resolved Hide resolved
src/CommonITILValidation.php Outdated Show resolved Hide resolved
src/CommonITILValidation.php Outdated Show resolved Hide resolved
src/CommonITILValidation.php Outdated Show resolved Hide resolved
templates/components/itilobject/validation.html.twig Outdated Show resolved Hide resolved
templates/components/itilobject/validation.html.twig Show resolved Hide resolved
@Lainow Lainow requested a review from cconard96 September 23, 2024 14:45
@Lainow Lainow requested a review from cconard96 September 24, 2024 07:33
cconard96
cconard96 suggested changes Sep 24, 2024
View reviewed changes
src/CommonITILValidation.php Outdated Show resolved Hide resolved
src/CommonITILValidation.php Outdated Show resolved Hide resolved
src/CommonITILValidation.php Outdated Show resolved Hide resolved
src/CommonITILValidation.php Outdated Show resolved Hide resolved
src/CommonITILValidation.php Outdated Show resolved Hide resolved
src/CommonITILValidation.php Outdated Show resolved Hide resolved
src/CommonITILValidation.php Outdated Show resolved Hide resolved
src/CommonITILValidation.php Outdated Show resolved Hide resolved
templates/components/itilobject/validation.html.twig Outdated Show resolved Hide resolved
templates/components/itilobject/validation.html.twig Outdated Show resolved Hide resolved
@Lainow Lainow requested a review from cconard96 September 24, 2024 13:19
@Lainow Lainow requested a review from cedric-anne September 24, 2024 14:05
@cedric-anne cedric-anne force-pushed the twig-update-approvaltab branch from e6f93f5 to f5d6d04 Compare September 25, 2024 19:50
@cedric-anne cedric-anne merged commit 38e0ae2 into glpi-project:main Sep 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedric-anne cedric-anne cedric-anne approved these changes

@cconard96 cconard96 cconard96 approved these changes

Assignees

@Lainow Lainow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lainow @cconard96 @cedric-anne