-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Access errors and session's "exit" fixes #17888
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierstoval
force-pushed
the
access-errors
branch
from
September 18, 2024 09:53
237f78a
to
b3398ff
Compare
cedric-anne
reviewed
Sep 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems OK so far.
Pierstoval
force-pushed
the
access-errors
branch
5 times, most recently
from
September 23, 2024 13:12
5c3f6e6
to
57e0350
Compare
Pierstoval
changed the title
[WIP] Access errors and session's "exit" fixes
Access errors and session's "exit" fixes
Sep 23, 2024
Pierstoval
force-pushed
the
access-errors
branch
from
September 23, 2024 15:21
57e0350
to
e42cde7
Compare
cedric-anne
reviewed
Sep 24, 2024
Pierstoval
force-pushed
the
access-errors
branch
from
September 26, 2024 08:25
e42cde7
to
3669214
Compare
…rController instead
Pierstoval
force-pushed
the
access-errors
branch
from
October 2, 2024 11:10
3669214
to
909c63f
Compare
cedric-anne
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.