-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(forms): Add Entity field configuration for form destination #17678
Merged
cedric-anne
merged 3 commits into
glpi-project:main
from
ccailly:feature/form-destination-config-fields-entity
Sep 30, 2024
Merged
feat(forms): Add Entity field configuration for form destination #17678
cedric-anne
merged 3 commits into
glpi-project:main
from
ccailly:feature/form-destination-config-fields-entity
Sep 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just looked at the last commit, probably need to wait for merge and rebase of others PRs to test this one.
phpunit/functional/Glpi/Form/Destination/CommonITILField/EntityFieldTest.php
Show resolved
Hide resolved
Need #17650 to be merged first. |
ccailly
force-pushed
the
feature/form-destination-config-fields-entity
branch
2 times, most recently
from
September 10, 2024 09:19
67faf42
to
b9b3dfe
Compare
ccailly
force-pushed
the
feature/form-destination-config-fields-entity
branch
5 times, most recently
from
September 12, 2024 13:49
81c1b3b
to
0ad9e1b
Compare
ccailly
force-pushed
the
feature/form-destination-config-fields-entity
branch
from
September 19, 2024 08:21
0ad9e1b
to
8e24c3c
Compare
AdrienClairembault
approved these changes
Sep 23, 2024
cedric-anne
reviewed
Sep 23, 2024
src/Glpi/Form/Destination/CommonITILField/EntityFieldStrategy.php
Outdated
Show resolved
Hide resolved
ccailly
force-pushed
the
feature/form-destination-config-fields-entity
branch
from
September 23, 2024 13:44
8e24c3c
to
647d900
Compare
ccailly
force-pushed
the
feature/form-destination-config-fields-entity
branch
from
September 24, 2024 08:31
647d900
to
b61cb0f
Compare
cedric-anne
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible configurations :
"Specific entity" display a secondary select to let the user pick the chosen Entity :
"Answer from a specific question" display a secondary select to let the user pick the chosen question :