Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(forms): Add Entity field configuration for form destination #17678

Conversation

ccailly
Copy link
Member

@ccailly ccailly commented Aug 13, 2024

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets

image

Possible configurations :
image

"Specific entity" display a secondary select to let the user pick the chosen Entity :
image

"Answer from a specific question" display a secondary select to let the user pick the chosen question :
image

@ccailly ccailly self-assigned this Aug 13, 2024
@ccailly ccailly added this to the 11.0.0 milestone Aug 13, 2024
Copy link
Contributor

@AdrienClairembault AdrienClairembault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just looked at the last commit, probably need to wait for merge and rebase of others PRs to test this one.

@ccailly ccailly marked this pull request as draft August 14, 2024 13:19
@ccailly
Copy link
Member Author

ccailly commented Aug 14, 2024

Need #17650 to be merged first.

@orthagh orthagh added the Forms label Aug 23, 2024
@ccailly ccailly force-pushed the feature/form-destination-config-fields-entity branch 2 times, most recently from 67faf42 to b9b3dfe Compare September 10, 2024 09:19
@ccailly ccailly force-pushed the feature/form-destination-config-fields-entity branch 5 times, most recently from 81c1b3b to 0ad9e1b Compare September 12, 2024 13:49
@ccailly ccailly force-pushed the feature/form-destination-config-fields-entity branch from 0ad9e1b to 8e24c3c Compare September 19, 2024 08:21
@ccailly ccailly marked this pull request as ready for review September 19, 2024 14:02
@ccailly ccailly force-pushed the feature/form-destination-config-fields-entity branch from 8e24c3c to 647d900 Compare September 23, 2024 13:44
@ccailly ccailly force-pushed the feature/form-destination-config-fields-entity branch from 647d900 to b61cb0f Compare September 24, 2024 08:31
@cedric-anne cedric-anne merged commit 78cfe12 into glpi-project:main Sep 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants