IP Address list to twig datatable #16368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orthagh
approved these changes
Jan 15, 2024
trasher
approved these changes
Jan 15, 2024
cedric-anne
force-pushed
the
ui/twig_migrations_4
branch
from
0f9806c to
2fd4ca4
Compare
cedric-anne
approved these changes
Jan 15, 2024
cedric-anne
reviewed
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace use of HTMLTable* classes to display the list of IP Addresses on the IP Addresses tab of IP Networks with a Twig datatable.
Before:
After:
The "Automatic Inventory" column was possible to show using the HTMLTable methods but it was hidden behind an option which was never set anywhere. The old HTMLTable methods were left in place as they were used in at least one other location for another table. That other table wasn't migrated yet as it relies on special grouping/rowspan behavior which is not possible in the datatable template yet.