ITIL template field twig ui #16366
ITIL template field twig ui #16366
Conversation
I'm not sure that issue is unique to my changes in this PR. Do you have a field added from a plugin that isn't enabled anymore? Both with this PR and in the main branch, it seems to try accessing the name of all added fields from the list of allowed ones without a check to see if they still exist. |
|
You're right, concerned option seems to be part of an inactive/uninstalled plugin |
| }) }} | ||
| {{ extra_form_html|raw }} | ||
| {% if show_submit %} | ||
| <div class="ms-2">{{ inputs.submit('add', _x('button', 'Add')) }}</div> |
There was a problem hiding this comment.
@cconard96 _x() will not be detected by xgettext here.
I suggest to move this template into a dedicated Twig file. You could, inside this file, include components/datatable.html.twig, in order to have a single call to TemplateRenderer::getInstance()->display() inside the current method.
Migrate form/list for hidden, readonly, mandatory and predefined ITIL template fields to Twig and de-duplicate the display code.