Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar dropdown and Database Instance Twig UI #16364

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

cconard96
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -

Copy link
Contributor

@orthagh orthagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good apart minor point:
Like #16361, massive action button above the datatable should be spaced a little

@cconard96
Copy link
Contributor Author

massive action button ui fixed in other PR.

Copy link
Contributor

@trasher trasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase to solve conflict

src/CalendarSegment.php Outdated Show resolved Hide resolved
src/Calendar_Holiday.php Outdated Show resolved Hide resolved
templates/generic_show_form.html.twig Outdated Show resolved Hide resolved
templates/generic_show_form.html.twig Outdated Show resolved Hide resolved
@cedric-anne cedric-anne requested a review from trasher January 23, 2024 14:31
@cedric-anne cedric-anne added this to the 10.1.0 milestone Jan 23, 2024
@cedric-anne cedric-anne dismissed trasher’s stale review January 24, 2024 13:20

Changes were made.

@trasher trasher merged commit 49d85fe into glpi-project:main Jan 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants