fix(Notification): fix conversion of relative URLs to aboslue URLs

[stonebuzz]

Since the replacement of htmlawed

the symfony component used to make HTML safe encodes = with =

<a href="/front/document.send.php?docid&#61;9122&amp;itemtype&#61;Ticket&amp;items_id&#61;38142" target="_blank" rel="noopener"><img src="/front/document.send.php?docid&#61;9122&amp;itemtype&#61;Ticket&amp;items_id&#61;38142" alt="d40c9e53-f37490bd-63ec57f1a8efc3.58665698" width="4032" /></a>

GLPI's notification system tries to convert relative URLs into absolute URLs via a reg_replace

foreach ($inline_docs as $docID => $filename) {
    $current->fields['body_html'] = preg_replace(
        [
            '/src=["\'][^"\']*document\.send\.php\?docid=' . $docID . '(&[^"\']+)?["\']/',
            '/href=["\'][^"\']*document\.send\.php\?docid=' . $docID . '(&[^"\']+)?["\']/',
        ],
        [
            // 'cid' must be identical as second arg used in `embedFromPath` method
            // Symfony/Mime will then replace it by an auto-generated value
            // see Symfony\Mime\Email::prepareParts()
            'src="cid:' . $filename . '"',
            'href="' . $CFG_GLPI['url_base'] . '/front/document.send.php?docid=' . $docID . '$1"',
        ],
        $current->fields['body_html']
    );
}

Method no longer works due to the HTML encoding of =

I'm not an expert in HTML encoding/decoding, so this commit is a first test to see how the unit tests behave.

Perhaps another solution would be to adapt the REGEXs to match =

Q	A
Bug fix?	yes/no
New feature?	yes/no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	!28203

[cedric-anne]

I think the only solution to fix it quickly will be to adapt all regex to use (?:=|=) instead of =. Usage of ?: to prevent capture would help to prevent any impact on results indexes.

[cedric-anne]

It seems OK, but I would like to make some tests before giving a validation.