Fix entity selector #16306
Closed
Fix entity selector #16306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#16249 ? |
|
Is this meant as a replacement for #16249? |
|
My bad, I didn't know it was already solved by #16249. |
|
I have no idea which approach is better, guess we can let @cedric-anne look into it when he comes back. Probably a mix of both approach would be best as I understand that you implements additional improvements (like profiler support) while this PR add some tests which are probably needed on this feature. |
|
Also, a third solution would be to revert #15794 and work on this on the main branch instead to avoid futures issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The entity selector is never updated, meaning any new entities will never be visible.
This is caused by #15794, which did not take cache invalidation into account.
I've fixed this by adding a hash of every entities last update date into the selector.
This hash will change any time an entity is created, updated or deleted from the database.
I've also deleted references to the old cache key since it is not used anymore after #15794.