Enhance password expiration message #16210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trasher
reviewed
Dec 18, 2023
trasher
reviewed
Dec 18, 2023
trasher
approved these changes
Dec 18, 2023
trasher
reviewed
Dec 18, 2023
trasher
reviewed
Dec 19, 2023
cedric-anne
changed the title
cedric-anne
requested changes
Dec 19, 2023
cedric-anne
force-pushed
the
enhance/password_exp_msg
branch
from
ba8b4fd to
5564c15
Compare
cedric-anne
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When impersonating a user who has never had their password changed, and when the password expiration policy is set, the warning on the user's homepage says the password will expire in 1970. It also shows a debug error because 'password_last_update' is null and passing null to strtotime is deprecated. This PR prevents passing null to strtotime and also changes the message to "Your password has expired." when the expiration date has passed.