fix(config): historical tab empty (#15968)

* fix(config): historical tab empty * add test
glpi-project · Nov 9, 2023 · e3cd042 · e3cd042
1 parent be10135
commit e3cd042
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/Config.php b/src/Config.php
@@ -4020,12 +4020,11 @@ public static function getConfigIDForContext(string $context)
         /** @var \DBmysql $DB */
         global $DB;
         $iterator = $DB->request([
-            'SELECT' => 'id',
+            'SELECT' => ['MIN' => 'id AS id'],
             'FROM'   => self::getTable(),
             'WHERE'  => [
                 'context' => $context,
             ],
-            'LIMIT'  => 1,
         ]);
         if (count($iterator)) {
             return $iterator->current()['id'];

diff --git a/tests/functional/Config.php b/tests/functional/Config.php
@@ -923,4 +923,13 @@ public function testDetectRooDoc(): void
             }
         }
     }
+
+    public function testConfigLogNotEmpty()
+    {
+        $itemtype = 'Config';
+        $config_id = \Config::getConfigIDForContext('core');
+        $this->integer($config_id)->isGreaterThan(0);
+        $total_number = countElementsInTable("glpi_logs", ['items_id' => $config_id, 'itemtype' => $itemtype]);
+        $this->integer($total_number)->isGreaterThan(0);
+    }
 }