Fix debug bar on global search page (#16226)

* fix debug bar on global search page * load only requested lib on debug mode --------- Co-authored-by: Cédric Anne <[email protected]>
glpi-project · Jan 18, 2024 · cd46a36 · cd46a36
1 parent 3b109f8
commit cd46a36
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/src/Html.php b/src/Html.php
@@ -1147,7 +1147,12 @@ public static function includeHeader(
         $tpl_vars['css_files'][] = ['path' => 'public/lib/photoswipe.css'];
         Html::requireJs('photoswipe');
 
-       //on demand JS
+        if ($_SESSION['glpi_use_mode'] === Session::DEBUG_MODE) {
+            $tpl_vars['css_files'][] = ['path' => 'public/lib/codemirror.css'];
+            Html::requireJs('codemirror');
+        }
+
+        //on demand JS.
         if ($sector != 'none' || $item != 'none' || $option != '') {
             $jslibs = [];
             if (isset($CFG_GLPI['javascript'][$sector])) {
@@ -1236,7 +1241,10 @@ public static function includeHeader(
                 Html::requireJs('charts');
             }
 
-            if (in_array('codemirror', $jslibs) || $_SESSION['glpi_use_mode'] === Session::DEBUG_MODE) {
+            if (
+                in_array('codemirror', $jslibs)
+                && $_SESSION['glpi_use_mode'] !== Session::DEBUG_MODE // codemirror is already loaded when debug mode is active
+            ) {
                 $tpl_vars['css_files'][] = ['path' => 'public/lib/codemirror.css'];
                 Html::requireJs('codemirror');
             }