Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nanobind port: Order module #1281

Draft
wants to merge 7 commits into
base: nanobind
Choose a base branch
from
Draft

Nanobind port: Order module #1281

wants to merge 7 commits into from

Conversation

janbridley
Copy link
Contributor

@janbridley janbridley commented Sep 11, 2024

Description

Work toward converting the code to nano bind. Currently, the freud/order/nematic has been 100% translated (with tests passing). @seoulfood has been working to convert the other modules and will reintegrate soon.

TODOs:

  • Nematic
  • ContinuousCoordination
  • Cubatic
  • Hexatic
  • Steinhardt
  • RotationalAutocorrelation
  • SolidLiquid (blocked by clusters module)

How Has This Been Tested?

No tests have been modified to ensure the user-facing behavior remains constant. Tests for Nematic now pass.

Screenshots

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds or improves functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation improvement (updates to user guides, docstrings, or developer docs)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • All new and existing tests passed.
  • I have updated the credits.
  • I have updated the Changelog.

@janbridley janbridley changed the title Update order/Nematic Nanobind port: Order module Sep 11, 2024
@janbridley janbridley self-assigned this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant