-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📚🩹 Use fixed pydata-sphinx-theme from fork #334
Conversation
Reviewer's Guide by SourceryThis pull request addresses a PDF building issue by switching to a forked version of No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #334 +/- ##
=======================================
Coverage 58.04% 58.04%
=======================================
Files 31 31
Lines 1616 1616
Branches 213 213
=======================================
Hits 938 938
Misses 660 660
Partials 18 18 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the build env as well. :)
Today I found that our docs are broken due to a bug when building PDFs.
This PR changes the pydata-sphinx-theme from the published upstream project to a branch on my for including the following fixes:
I also went ahead and removed the workaround on our side since it isn't needed with the fix on my fork in place.
Change summary
Checklist
Summary by Sourcery
Bug Fixes: