-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚇🩹 Fix pinned min pydantic lower than min required package version #299
Conversation
🧹 Sort pinned min version in the same order package requirements
🧙 Sourcery has finished reviewing your pull request! Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #299 +/- ##
=======================================
Coverage 58.26% 58.26%
=======================================
Files 31 31
Lines 1598 1598
Branches 290 290
=======================================
Hits 931 931
Misses 651 651
Partials 16 16 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice use of uv! 👍
This change fixes the failing
test-min-versions
workflow.The workflow fails because installing the package requires
pydantic>=2.7
where as the pinned min dependencies usepydantic==2.4.0
, leading to an upgrade to a current pydantic (>=2.9) leading to a failing test due to a change in the json schema.Change summary
Checklist