Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚇 Add CODECOV_TOKEN #268

Merged
merged 1 commit into from
Jun 8, 2024
Merged

Conversation

s-weigand
Copy link
Member

@s-weigand s-weigand commented Jun 7, 2024

The action codecov/codecov-action@v4 removed support for tokenless uploads so pushes to main failed upload coverage reports for the last 3 months.
However, uploads from PRs done by forks still work. so this issue can only be seen for pushes on main

Change summary

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)

The action codecov/codecov-action@v4 removed support for tokenless uploads so pushes to main failed upload coverage reports for the last 3 months
@s-weigand s-weigand requested a review from a team as a code owner June 7, 2024 15:15
Copy link
Contributor

sourcery-ai bot commented Jun 7, 2024

🧙 Sourcery is reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

Copy link
Contributor

github-actions bot commented Jun 7, 2024

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran-extras/code-cov-token

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.77%. Comparing base (b880df9) to head (be7234a).
Report is 20 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #268   +/-   ##
=======================================
  Coverage   44.77%   44.77%           
=======================================
  Files          27       27           
  Lines        1043     1043           
  Branches      162      162           
=======================================
  Hits          467      467           
  Misses        568      568           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@s-weigand s-weigand merged commit 291774e into glotaran:main Jun 8, 2024
31 checks passed
@s-weigand s-weigand deleted the code-cov-token branch June 8, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants