Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fetch_or_initialize return object #91

Merged
merged 1 commit into from
Dec 1, 2023
Merged

fix: fetch_or_initialize return object #91

merged 1 commit into from
Dec 1, 2023

Conversation

HassanAkbar
Copy link
Member

There was a bug in fetch_or_initialize method inside ManagedConceptCollection class that it was returning a string in case the concept is initialized.

fixes metanorma/stepmod-utils#198

@HassanAkbar HassanAkbar requested a review from ronaldtse December 1, 2023 12:59
@ronaldtse ronaldtse merged commit 8756a5c into main Dec 1, 2023
14 checks passed
@ronaldtse ronaldtse deleted the fixing_bug_with_fetch_or_initialize branch December 1, 2023 13:33
@HassanAkbar
Copy link
Member Author

@ronaldtse released version 2.0.2 with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronaldtse ronaldtse ronaldtse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed specs using new Glossarist 2.0 gem
2 participants
@HassanAkbar @ronaldtse