Glossarist v2 enhancements and fixes #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HassanAkbar thanks for this! Could you please try:
This is related to this task: |
|
At the iso-iec-2382 repository: $ bundle exec termium convert -i reference-docs/xml/ISO-IEC_2382.xml -o sources/concepts
Reading TERMIUM export file: reference-docs/xml/ISO-IEC_2382.xml
Size of TERMIUM dataset: 3263
Converting to Glossarist...
Using existing directory: sources/concepts
Writing Glossarist dataset to: sources/concepts
bundler: failed to load command: termium (/Users/me/.asdf/installs/ruby/3.1.2/lib/ruby/gems/3.1.0/bin/termium)
/Users/me/.asdf/installs/ruby/3.1.2/lib/ruby/gems/3.1.0/bundler/gems/glossarist-ruby-915cf0005a43/lib/glossarist/concept_manager.rb:64:in `save_concept_to_file': undefined method `each' for nil:NilClass (NoMethodError)
concept.localized_concepts.each do |lang, uuid|
^^^^^
from /Users/me/.asdf/installs/ruby/3.1.2/lib/ruby/gems/3.1.0/bundler/gems/glossarist-ruby-915cf0005a43/lib/glossarist/concept_manager.rb:32:in `each_value'
from /Users/me/.asdf/installs/ruby/3.1.2/lib/ruby/gems/3.1.0/bundler/gems/glossarist-ruby-915cf0005a43/lib/glossarist/concept_manager.rb:32:in `save_to_files'
from /Users/me/.asdf/installs/ruby/3.1.2/lib/ruby/gems/3.1.0/bundler/gems/glossarist-ruby-915cf0005a43/lib/glossarist/managed_concept_collection.rb:76:in `save_to_files'
from /Users/me/.asdf/installs/ruby/3.1.2/lib/ruby/gems/3.1.0/gems/termium-0.1.2/lib/termium/cli.rb:58:in `convert'
from /Users/me/.asdf/installs/ruby/3.1.2/lib/ruby/gems/3.1.0/gems/thor-1.2.2/lib/thor/command.rb:27:in `run' |
|
Thanks @HassanAkbar I can see the concept dataset format is now correct. In this case, can you please help update the metanorma-plugin-glossarist plugin to work with the new dataset as well? There are 2 documents that use metanorma-plugin-glossarist we need to update: |
|
@ronaldtse created a new issue for this change here -> metanorma/metanorma-plugin-glossarist#20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
noteanddesignationsave_to_filesto save in Glossarist V2 Formatcloses #82
closes #84