🏗️ Support external auth provider login. #80
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danieloni1
force-pushed
the
daniel/dev-1065-geodome-type-login
branch
from
f7bfe20 to
3e6876f
Compare
Danieloni1
force-pushed
the
daniel/dev-1065-geodome-type-login
branch
from
3e6876f to
6595cdb
Compare
Danieloni1
force-pushed
the
daniel/dev-1065-geodome-type-login
branch
3 times, most recently
from
c847a96 to
017d6a4
Compare
Danieloni1
force-pushed
the
daniel/dev-1065-geodome-type-login
branch
from
017d6a4 to
11ac687
Compare
Danieloni1
force-pushed
the
daniel/dev-1065-geodome-type-login
branch
from
a80fb7c to
3e971ff
Compare
danpe
requested changes
Dec 27, 2023
| loginFlows = append(loginFlows, flow{Type: authtypes.LoginTypeDummy}) | ||
| loginFlows = append(loginFlows, flow{Type: authtypes.LoginTypeEmail}) | ||
| loginFlows = append(loginFlows, flow{Type: authtypes.LoginTypeJwt}) | ||
| loginFlows = append(loginFlows, flow{Type: authtypes.LoginTypeGeodome}) |
There was a problem hiding this comment.
@Danieloni1 why appending Geodome twice?
| @@ -72,6 +72,8 @@ type Login struct { | |||
| // Thus a pointer is needed to differentiate between the two | |||
| InitialDisplayName *string `json:"initial_device_display_name"` | |||
| DeviceID *string `json:"device_id"` | |||
|
|
|||
| ExternalAuthResp interface{} `json:"external_auth_response"` | |||
There was a problem hiding this comment.
@Danieloni1 do we need this as part of UserInteractive?
| AccessToken string `json:"access_token"` | ||
| HomeServer spec.ServerName `json:"home_server"` | ||
| DeviceID string `json:"device_id"` | ||
| ExternalAuthResp interface{} `json:"external_auth_response,omitempty"` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.