Fix conditionals bug update tests #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's closer to prod's 3.6.9, and not failing mysteriously
shaunagm
force-pushed
the
fix-conditionals-bug-update-tests
branch
from
766dcd2 to
753d6e6
Compare
|
WHY does this keep failing on Github Actions but not locally? I guess it's probably something to do with the version of Chrome or the Chromedriver that Github Actions installs, since that's the main thing that could be different between the two, but I have no idea how to debug this. |
|
Ok, since the tests are running fine locally and there's only this one error, I'm going to merge this, but flagging this as a bug for later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also contains an update with custom error pages.