Skip to content
This repository has been archived by the owner on Jan 15, 2022. It is now read-only.

Allow specifying table rows in custom components #196

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Allow specifying table rows in custom components #196

wants to merge 5 commits into from

Commits on Oct 3, 2015

  1. Added failing test for rendering sub components

    @trshafer @glittershark
    trshafer authored and glittershark committed Oct 3, 2015
    Configuration menu
    Copy the full SHA
    71b81bf View commit details
    Browse the repository at this point in the history

  2. prototype solution to custom components 

    Since react will not render child components until the parent component
is rendered (exploratory hypotheis) We need to render the custom
component first and then access the component.  This uses a Component
function of getData().  The getData function could/should be fast
because after the render function all the data could be available via
props or state

I have not tested this with updating data from the custom component.  Or
if the custom component internally changes the data and they table needs
to resort.
    @trshafer @glittershark
    trshafer authored and glittershark committed Oct 3, 2015
    Configuration menu
    Copy the full SHA
    570cfd1 View commit details
    Browse the repository at this point in the history

  3. Revert "prototype solution to custom components" 

    This reverts commit 1fc822d.
    @glittershark
    glittershark committed Oct 3, 2015
    Configuration menu
    Copy the full SHA
    3bd8e5a View commit details
    Browse the repository at this point in the history

  4. Allow specifying table rows in custom components 

    Use the structure returned by `react.createElement` to do a render of
any child components with unrecognized types, and extract the data out
of them if they themselves return a `<Tr>`
    @glittershark
    glittershark committed Oct 3, 2015
    Configuration menu
    Copy the full SHA
    7a937ca View commit details
    Browse the repository at this point in the history

  5. Handle passing through context to child components 

    When instantiating child components in order to render them, also pass
through the props given when creating the child component.
    @glittershark
    glittershark committed Oct 3, 2015
    Configuration menu
    Copy the full SHA
    3ca5bb7 View commit details
    Browse the repository at this point in the history