Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backtracking re-render during lazy initialization #1632

Closed
wants to merge 2 commits into from
Closed

Conversation

Copy link

duration phase no difference [-127ms to 84ms]
renderEnd phase no difference [-1ms to 2ms]
render1000Items1End phase no difference [-2ms to 18ms]
clearItems1End phase no difference [-2ms to 4ms]
render1000Items2End phase no difference [-7ms to 13ms]
clearItems2End phase no difference [0ms to 1ms]
render5000Items1End phase no difference [-20ms to 30ms]
clearManyItems1End phase no difference [-2ms to 3ms]
render5000Items2End phase no difference [-39ms to 35ms]
clearManyItems2End phase no difference [-3ms to 1ms]
render1000Items3End phase no difference [-18ms to 17ms]
append1000Items1End phase no difference [-38ms to 19ms]
append1000Items2End phase no difference [-16ms to 3ms]
updateEvery10thItem1End phase no difference [-1ms to 0ms]
updateEvery10thItem2End phase no difference [-14ms to 0ms]
selectFirstRow1End phase no difference [0ms to 0ms]
selectSecondRow1End phase no difference [0ms to 0ms]
removeFirstRow1End phase no difference [-1ms to 1ms]
removeSecondRow1End phase no difference [-1ms to 0ms]
swapRows1End phase no difference [-1ms to 0ms]
swapRows2End phase no difference [-1ms to 0ms]
clearItems4End phase no difference [-2ms to 1ms]
paint phase no difference [0ms to 0ms]

[20:43:56] Generating Benchmark Reports [started]
[20:44:05] Generating Benchmark Reports [completed]

Benchmark Reports    

JSON: /home/runner/work/glimmer-vm/glimmer-vm/tracerbench-results/compare.json

PDF: /home/runner/work/glimmer-vm/glimmer-vm/tracerbench-results/artifact-1.pdf

HTML: /home/runner/work/glimmer-vm/glimmer-vm/tracerbench-results/artifact-1.html

@NullVoxPopuli
Copy link
Contributor Author

This isn't a reproduction as errors manifest on older VM versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant