[perf] replace Math.max usage to reduce and pure compare

glimmerjs · Dec 5, 2023 · e099bd9 · e099bd9
1 parent 7b9b0cf
commit e099bd9
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/packages/@glimmer/validator/lib/validators.ts b/packages/@glimmer/validator/lib/validators.ts
@@ -137,19 +137,19 @@ class MonomorphicTagImpl<T extends MonomorphicTagId = MonomorphicTagId> {
 
         if (subtag !== null) {
           if (Array.isArray(subtag)) {
-            for (const tag of subtag) {
-              let value = tag[COMPUTE]();
-              revision = Math.max(value, revision);
-            }
+            revision = subtag.reduce((prev, currentTag: Tag) => {
+              let current = currentTag[COMPUTE]();
+              return current > prev ? current : prev;
+            }, revision);
           } else {
             let subtagValue = subtag[COMPUTE]();
 
             if (subtagValue === this.subtagBufferCache) {
-              revision = Math.max(revision, this.lastValue);
+              revision = revision > this.lastValue ? revision : this.lastValue;
             } else {
               // Clear the temporary buffer cache
               this.subtagBufferCache = null;
-              revision = Math.max(revision, subtagValue);
+              revision = revision > subtagValue ? revision : subtagValue;
             }
           }
         }