ci: add windows to matrix tests

Fixes philippgille#140 Signed-off-by: Boris Glimcher <[email protected]>
glimchb · Nov 7, 2023 · af6f1be · af6f1be
1 parent 087cefb
commit af6f1be
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -6,10 +6,12 @@ on:
   pull_request:
 jobs:
   build:
-    runs-on: ubuntu-latest
     strategy:
+      fail-fast: false
       matrix:
         go: [ '1.18', '1.19', '1.20', '1.21' ]
+        os: [windows-latest, ubuntu-latest]
+    runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v3

diff --git a/magefiles/magefile.go b/magefiles/magefile.go
@@ -17,7 +17,7 @@ import (
 func Update() error {
 	switch runtime.GOOS {
 	case "windows":
-		return sh.Run("./build/update-deps.ps1")
+		return sh.Run("pwsh.exe", "./build/update-deps.ps1")
 	case "darwin":
 		fallthrough
 	case "linux":
@@ -30,7 +30,7 @@ func Update() error {
 func Build() error {
 	switch runtime.GOOS {
 	case "windows":
-		return sh.Run("./build/build.ps1")
+		return sh.Run("pwsh.exe", "./build/build.ps1")
 	case "darwin":
 		fallthrough
 	case "linux":

diff --git a/magefiles/test.go b/magefiles/test.go
@@ -6,6 +6,7 @@ import (
 	"errors"
 	"fmt"
 	"os"
+	"runtime"
 	"strings"
 	"time"
 
@@ -30,6 +31,11 @@ func testImpl(impl string) error {
 		return err
 	}
 
+	// TODO: until docker images for windows appear, skip those test for windows
+	if runtime.GOOS == "windows" {
+		return nil
+	}
+
 	// Implementations that require a separate service
 
 	var err error