Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for hsm templates #3040

Closed
wants to merge 13 commits into from
Closed

Fix for hsm templates #3040

wants to merge 13 commits into from

Conversation

akanshaaa19
Copy link
Member

target issues are #3005 #3009

@akanshaaa19 akanshaaa19 self-assigned this Aug 26, 2024
Copy link

github-actions bot commented Aug 26, 2024

@github-actions github-actions bot temporarily deployed to pull request August 26, 2024 03:09 Inactive
Copy link

cypress bot commented Aug 26, 2024

Glific    Run #5149

Run Properties:  status check failed Failed #5149  •  git commit 1c7679c485 ℹ️: Merge 36b3b6211f2d25f110d298a76f0dc2c2bd91f8d5 into cab883c6bcce3d21d958d092a6cc...
Project Glific
Branch Review fix/hsm
Run status status check failed Failed #5149
Run duration 25m 34s
Commit git commit 1c7679c485 ℹ️: Merge 36b3b6211f2d25f110d298a76f0dc2c2bd91f8d5 into cab883c6bcce3d21d958d092a6cc...
Committer Akansha Sakhre
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 168
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/notification/notification.spec.ts • 1 failed test

View Output

Test Artifacts
Notification list > downloads csv report for contact import Test Replay Screenshots

@github-actions github-actions bot temporarily deployed to pull request August 27, 2024 15:33 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 27, 2024 15:45 Inactive
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 80.95238% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.19%. Comparing base (cab883c) to head (36b3b62).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
src/containers/Template/Form/Template.tsx 77.77% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3040      +/-   ##
==========================================
- Coverage   80.29%   80.19%   -0.10%     
==========================================
  Files         322      322              
  Lines       10364    10373       +9     
  Branches     2208     2216       +8     
==========================================
- Hits         8322     8319       -3     
- Misses       1401     1405       +4     
- Partials      641      649       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akanshaaa19 akanshaaa19 requested a review from kurund August 27, 2024 16:27
@github-actions github-actions bot temporarily deployed to pull request August 27, 2024 20:29 Inactive
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akanshaaa19

  • Copy of HSM still not working. See below, not sure if it's related to this fix.
Screenshot 2024-08-27 at 21 36 26

@github-actions github-actions bot temporarily deployed to pull request August 27, 2024 22:39 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 30, 2024 16:15 Inactive
@akanshaaa19 akanshaaa19 requested a review from kurund August 30, 2024 16:22
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss this on the call.

@akanshaaa19
Copy link
Member Author

Separated the PR:
#3056
#3054

@akanshaaa19 akanshaaa19 closed this Sep 3, 2024
@AkhileshNegi AkhileshNegi deleted the fix/hsm branch December 6, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HSM Template: Adding fallback image HSM Template: copy is not working
2 participants