Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non-browser websocket clients to access the /logs endpoint #502

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

semk
Copy link

@semk semk commented Feb 23, 2021

websocket.Handler.ServeHTTP serves to browser requests and was also causing logspout to crash when accessed by a client like wscat as they don't typically set the origin header (See #412). This change bypasses the validation for origin header.

  websocket.Handler only serves to browser requests and was causing
  logspout to crash when accessed by a client like wscat (See
  gliderlabs#412)
@michaelshobbs
Copy link
Member

Thanks for the contribution. Thoughts on a unit test or two for this and the package in general?

@6r17
Copy link

6r17 commented Nov 13, 2023

Hei ; the error is sill happening and non-browser client seem to have a problem using the ws endpoint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants