Allow non-browser websocket clients to access the /logs endpoint #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
websocket.Handler only serves to browser requests and was causing logspout to crash when accessed by a client like wscat (See gliderlabs#412)
|
Thanks for the contribution. Thoughts on a unit test or two for this and the package in general? |
|
Hei ; the error is sill happening and non-browser client seem to have a problem using the ws endpoint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
websocket.Handler.ServeHTTPserves to browser requests and was also causing logspout to crash when accessed by a client likewscatas they don't typically set the origin header (See #412). This change bypasses the validation for origin header.