Export a metrics endpoint for monitoring #325
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see the CI issue: Will install the package dependencies for the master branch, prometheus as a dependency, so its is a bit chicken and egg problem. |
| func init() { | ||
| pumpMsgSend = prometheus.NewCounterVec( | ||
| prometheus.CounterOpts{ | ||
| Name: "pump_msg_send", |
There was a problem hiding this comment.
All prometheus counter metrics should end in _total. Personally would call it logstash_sent_messages_total or logstash_messages_sent_total.
|
@progrium is this something you are willing to merge in general? I can help reviving this PR. There is probably a better way than initializing all this in init(). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find difficult to understand how logspout is behaving, one important metric for me is the rate of the sent msg per container. So we can identify peaks on the clusters easily but many other metrics can be really useful.
This PR expose a metric endpoint for prometheus that I can use to monitor logspout across my k8s cluster.
Feedback will be welcome.