Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give a deprecation warning when using the apk-install wrapper #269

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Give a deprecation warning when using the apk-install wrapper #269

wants to merge 1 commit into from

Conversation

pierreozoux
Copy link

No description provided.

This was referenced May 8, 2017
Closed
Closed
@andyshinn andyshinn self-requested a review May 8, 2017 16:12
andyshinn
andyshinn suggested changes May 8, 2017
View reviewed changes
Copy link
Contributor

@andyshinn andyshinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were originally going to do this in #18. I think this is probably fine. One request is that we should probably pipe the message to stderr like #18 did so it doesn't clobber normal output on stdout.

Ping @tianon. Is this something that we feel is fine for upstream?

@tianon
Copy link
Collaborator

tianon commented May 8, 2017

If it goes to stderr, yeah, seems sane to me -- though in the alpine images, this script is not included, right?

@andyshinn
Copy link
Contributor

Oh yea, you are right. It isn't even in library images. Disregard!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyshinn andyshinn andyshinn requested changes

Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pierreozoux @tianon @andyshinn