Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to new bs-platofrm 4.0.7 #10

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

upgrade to new bs-platofrm 4.0.7 #10

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32584be
upgrade to new bs-platofrm
jimmyhuco Nov 14, 2018
178e6f6
add or change some code after the review
jimmyhuco Nov 15, 2018
2c355b4
handwrite ocaml
jimmyhuco Nov 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
91 changes: 73 additions & 18 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ This has been heavily inspired by the [Rust Cookbook](https://brson.github.io/ru
* [Js.Dict](#jsdict)
* [Associative list](#associative-list)
* [Hashtbl](#hashtbl)
* [Belt.HashMap](#belthashmap)
+ [Use a Set in a recursive type](#use-a-set-in-a-recursive-type)
* [Promises](#promises)
+ [Creating new Promises](#creating-new-promises)
Expand Down Expand Up @@ -182,8 +183,10 @@ let () =
Use [Random module](http://caml.inria.fr/pub/docs/manual-ocaml/libref/Random.html) to generate random numbers

```ml
let () =
Js.log (Random.int 5)
(* To make sure you have a different seed when your program runs each time *)
let () = Random.init (Js.Date.now () |> int_of_float)

let () = Random.int 5 |> Js.log
```

#### Log a message to the console
Expand Down Expand Up @@ -239,7 +242,6 @@ let () =
| None ->
Js.log "no matches"
```

Or using [bs-revamp](https://github.com/glennsl/bs-revamp) with the same input:

```ml
Expand Down Expand Up @@ -269,6 +271,31 @@ let () =
*)
```

or use `Js.String`

```ml
let code = {|
let borderLeftColor = "borderLeftColor";
let borderRightColor = "borderRightColor";
|}

let matchLetter letter _ _ = "-" ^ (Js.String.toLowerCase letter)

let matchLiterals _ p1 _ _ =
let t = Js.String.unsafeReplaceBy0 [%re "/[A-Z]/g"] matchLetter p1 in {j|"$t"|j}

let () =
code
|> Js.String.unsafeReplaceBy1 [%re "/\"([^\"]*)\"/g"] matchLiterals
|> Js.log


(* Outputs:
let borderLeftColor = "border-left-color";
let borderRightColor = "border-right-color";
*)
```

#### Create a map data structure, add or replace an entry, and print each key/value pair

###### Map
Expand Down Expand Up @@ -370,6 +397,36 @@ let () =
painIndexMap |> Hashtbl.iter (fun k v -> Js.log {j|key:$k, val:$v|j})
```

###### Belt.HashMap

Use a generic `Belt.HashMap` to demo a mutable hash map with string type key. In fact, You can use `Belt.HashMap.String` instead.

```ml
open Belt
module StrHash =
Id.MakeHashable(struct
type t = string
let hash = String.length
let eq = (=)
end)

let painIndexMap = HashMap.make ~hintSize:10 ~id:(module StrHash)
let () =
let open HashMap in
set painIndexMap "western paper wasp" 1.0;
set painIndexMap "yellowjacket" 2.0;
set painIndexMap "honey bee" 2.0;
set painIndexMap "red paper wasp" 3.0;
set painIndexMap "tarantula hawk" 4.0;
set painIndexMap "bullet ant" 4.0

let () = HashMap.set painIndexMap "bumble bee" 2.0

let () =
HashMap.forEach painIndexMap
@@ fun k v -> Js.log {j|key:$k, val:$v|j}
```

#### Use a Set in a recursive type

The task is to make something like this using Set:
Expand Down Expand Up @@ -432,7 +489,7 @@ let timer =
accidentally partially apply the function *)
let _ : Js.Global.timeoutId =
Js.Global.setTimeout
(fun () -> (resolve "Done!")[@bs])
(fun () -> (resolve "Done!")[@bs])
1000
in ()
)
Expand All @@ -452,7 +509,7 @@ let _ : unit Js.Promise.t =
(* Chaining *)
let _ : unit Js.Promise.t =
Js.Promise.then_
(fun value -> Js.Promise.resolve (Js.log value))
(fun value -> Js.Promise.resolve (Js.log value))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't your doing, but I just noticed how weird it is to resolve the return value of Js.log. And being more explicit with Js.log value; Js.Promise.resolve () isn't much more verbose either. What do you think?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both ok. Js.Promise.resolve (Js.log value) is less code. I think everyone knows the return value from Js.log is unit.

(Js.Promise.then_
(fun value -> Js.Promise.resolve (value + 1))
(Js.Promise.resolve 1))
Expand All @@ -474,7 +531,7 @@ let _ : unit Js.Promise.t =
let open Js.Promise in
all2 (resolve 1, resolve "a")
|> then_ (fun (v1, v2) ->
Js.log ("Value 1: " ^ string_of_int v1);
Js.log ("Value 1: " ^ string_of_int v1);
Js.log ("Value 2: " ^ v2);
resolve ())

Expand Down Expand Up @@ -514,20 +571,20 @@ let _ : unit Js.Promise.t =
* In general, we should not rely on rejecting/catching errors for control flow;
* it's much better to use a `result` type instead.
*)
let betterOk : (string, _) Js.Result.t Js.Promise.t =
let betterOk : (string, _) Belt.Result.t Js.Promise.t =
Js.Promise.make (fun ~resolve ~reject:_ ->
resolve (Js.Result.Ok ("everything's fine")) [@bs])
resolve (Belt.Result.Ok ("everything's fine")) [@bs])

let betterOhNo : (_, string) Js.Result.t Js.Promise.t =
let betterOhNo : (_, string) Belt.Result.t Js.Promise.t =
Js.Promise.make (fun ~resolve ~reject:_ ->
resolve (Js.Result.Error ("nope nope nope")) [@bs])
resolve (Belt.Result.Error ("nope nope nope")) [@bs])

let handleResult =
Js.Promise.then_ (fun result ->
Js.Promise.resolve (
match result with
| Js.Result.Ok text -> Js.log ("OK: " ^ text)
| Js.Result.Error reason -> Js.log ("Oh no: " ^ reason)))
| Belt.Result.Ok text -> Js.log ("OK: " ^ text)
| Belt.Result.Error reason -> Js.log ("Oh no: " ^ reason)))

let _ : unit Js.Promise.t =
handleResult betterOk
Expand Down Expand Up @@ -713,8 +770,8 @@ external withAsyncCallback : ((Js.Json.t -> unit) -> unit) -> unit = "" [@@bs.va
let withAsyncCallback: (doneFn -> unit) -> unit =
fun f -> withAsyncCallback
(fun done_ ->
f (function | Some value -> value |> Js.Json.string |> done_
| None -> Js.false_ |> Js.Json.boolean |> done_))
f (function | Some value -> value |> Js.Json.string |> done_
| None -> false |> Js.Json.boolean |> done_))
```


Expand Down Expand Up @@ -774,7 +831,6 @@ let () =
## Node-specific

#### Read lines from a text file
Uses [bs-node](https://github.com/reasonml-community/bs-node)
```ml
let () =
Node.Fs.readFileAsUtf8Sync "README.md"
Expand All @@ -783,7 +839,7 @@ let () =
```

#### Read and parse a JSON file
Uses [bs-json](https://github.com/reasonml-community/bs-json) and [bs-node](https://github.com/reasonml-community/bs-node)
Uses [bs-json](https://github.com/reasonml-community/bs-json)
```ml
let decodeName text =
Js.Json.parseExn text
Expand All @@ -804,11 +860,10 @@ let () =
```

#### Run an external command
Uses [bs-node](https://github.com/reasonml-community/bs-node)
```ml
let () =
(* prints node's version *)
Node.(ChildProcess.execSync "node -v" (Options.options ~encoding:"utf8" ()))
Node.(Child_process.execSync "node -v" (Child_process.option ~encoding:"utf8" ()))
|> Js.log
```

Expand Down