Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile #4

Merged
merged 11 commits into from
Jul 27, 2020
Merged

Dockerfile #4

merged 11 commits into from
Jul 27, 2020

Conversation

joshmoore
Copy link
Contributor

@joshmoore joshmoore commented Mar 12, 2018

Adds a Dockerfile which builds the current code in a gradle layer and then deploys that to a vertx3 layer. Each merge to 0.5.x will then be deployed to Docker Hub as latest. Each tag will be deployed with the same value.

Simple testing instructions:

MS=ms-name
docker build -t $MS .
docker run -d --name redis redis
docker run --rm --link redis:redis $MS

Things to look into/discuss:

  • cleaner replacement of localhost with redis
    • is interpolation possible?
    • prefer mounting a config.yaml?
  • better base image (vertx/vertx3 unfortunately runs as root)
  • docker-specific configuration of logback
  • more sensible JAVA_OPTS defaults

@joshmoore joshmoore changed the base branch from master to 0.5.x July 23, 2020 10:18
@joshmoore
Copy link
Contributor Author

Updated base to 0.5.x and description to close #17

@chris-allan
Copy link
Member

Discussion with @joshmoore and @sbesson today. After setting the openmicroscopy DockerHub token we will merge this in to verify the GitHub Action and deposition to DockerHub. The medium/long term home for the Dockerfile will likely be openmicroscopy/omero-ms-thumbnail-docker to allow updates to the image without making new releases of omero-ms-thumbnail.

@chris-allan chris-allan merged commit a05072d into glencoesoftware:0.5.x Jul 27, 2020
@joshmoore joshmoore deleted the dockerfile branch July 27, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants