Upgrade to Vertx 4 #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbesson
reviewed
May 2, 2025
| @@ -5,7 +5,7 @@ plugins { | |||
| } | |||
|
|
|||
| group = 'com.glencoesoftware.omero' | |||
| version = '0.9.2-SNAPSHOT' | |||
There was a problem hiding this comment.
Was this change for testing locally?
There was a problem hiding this comment.
Yes, but also I imagine we'll want to increment the minor version number for a change like this.
There was a problem hiding this comment.
Yes, totally up for incrementing the minor version number for this. Could we make it 0.10.0-SNAPSHOT for now so that we can aim to merge this without necessarily calling it a full release?
Looking into #26 as it might be timely to move these API methods upstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to Vert.X 4.
See https://vertx.io/docs/guides/vertx-4-migration-guide/#handling_deprecations_and_removals_what-is-new-and-different-in-vertx-4
Promises were introduced in Vert.X 4, and so some changes were required to make new methods which utilize these Promises.
Also a couple other deprecated calls were changed.
Also two files were found to have Windows line endings so those were changed to Unix.