Skip to content

Fix #4565 #4595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix #4565 #4595

wants to merge 6 commits into from
+47 −1

Conversation

cysabi
Copy link

@cysabi cysabi commented May 13, 2025

  • Unsure if the test should be renamed
  • Unsure if the implementation belongs in visit.rs (where it is now) or as an override in QualifiedToUnqualifiedImportFirstPass

@cysabi cysabi mentioned this pull request May 13, 2025
Open
lpil
lpil approved these changes May 14, 2025
View reviewed changes
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Could you update the bugs section of the changelog please 🙏

@cysabi
Copy link
Author

cysabi commented May 15, 2025

is this right? 😭 sorry

@cysabi cysabi requested a review from lpil May 18, 2025 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpil lpil Awaiting requested review from lpil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cysabi @lpil