Make sure build tool does not try and run module whose main function is private #4593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpil
reviewed
May 14, 2025
compiler-core/src/error.rs
Outdated
| ), | ||
| level: Level::Error, | ||
| location: None, | ||
| hint: Some(format!("Make the `main` function in the `{module}` module public.")) |
There was a problem hiding this comment.
Should be good now!
giacomocavalieri
force-pushed
the
fix-main
branch
from
268e645 to
268b6d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #4592
The build tool would not check that the main function defined by a module is not private so
gleam runwould result in a runtime crash, instead of a build error