Feature/error pythonic import #4401
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `.` is really the problem in this instance, and so it seems better to point to it as the problem as opposed to the identifier
lpil
reviewed
Mar 29, 2025
Also fixes the whitespace for the error, which was found while examining the snapshot
…ythonic This changes the behavior so that `import one/two.three` issues the typical error, as `one/two` implies the user meant to use Gleam's import syntax, and likely just made a typo.
|
Alright :) As far as I can tell the points that you made are now resolved. Please let me know if there's a stylistic issue with any of the commits. |
andho
reviewed
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minimal improvement to address #3551. I don't have the knowledge in the code-base in order to implement the last suggestion, however I figured that a perfect solution shouldn't block a good solution.
Thus, here is hopefully the first of many contributions :)