attempt to fix star plugin after reload #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion it is just so much useful I currently use the generated talk id which does not react to changes in the schedule yet One way to solve this is to hash the talk object and identify the talk through hash
|
An idea could be to calculate a similarity using a diff algorithm. If a certain similarity was found, it is considered to be the same as the previous one. Of course, if the whole description changes, there's almost no similarity anymore. |
BattleRattle
added a commit
that referenced
this pull request
Mar 23, 2014
attempt to fix star plugin after reload
|
hmm, I could reuse the calculation used in the hange-notify plugin and define criterias when a talk is still the same talk— On Sun, Mar 23, 2014 at 5:09 PM, Norman Soetbeer [email protected]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I currently use the generated talk id which does not react to changes in the schedule yet
One way to solve this is to hash the talk object and identify the talk through hash
ideas?
#25