Let user specify the firebase app name #714
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@justinmann is attempting to deploy a commit to the Gladly Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kmjennison
requested changes
Jun 3, 2024
|
@justinmann If you don't plan on moving this forward, I could give it a try, as I think this might also help with the problems we are seeing that are blocking users from upgrading above @kmjennison Do you have any preference how to solve the dependency problem? There are a couple of ways this could be tackled, and I want to make sure it's going the direction you prefer. |
|
I gave it a try in #716. |
|
@MvRemmerden Thanks! Commented on that PR. |
|
Closed in #716. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safari / Firebase do not like each other: firebase/firebase-js-sdk#7888
To workaround their animosity, we need to change the app name for firebase to something without [].