Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore init bug, issue #614 / types reorganization #669

Draft
wants to merge 31 commits into
base: v1.x
Choose a base branch
from

Conversation

kmjennison
Copy link
Contributor

Exploring cause of #614.

@vercel
Copy link

vercel bot commented Jul 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nfa-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2023 6:00pm

@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (44475f8) 98.08% compared to head (fe7901a) 97.53%.

Files Patch % Lines
src/initFirebaseClientSDK.ts 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             v1.x     #669      +/-   ##
==========================================
- Coverage   98.08%   97.53%   -0.56%     
==========================================
  Files          31       31              
  Lines         887      891       +4     
  Branches      270      268       -2     
==========================================
- Hits          870      869       -1     
- Misses         17       22       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Conflicts:
#	example/package.json
#	example/yarn.lock
#	package.json
@kmjennison kmjennison changed the title Explore init bug, issue #614 Explore init bug, issue #614 / types reorganization Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant