Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix REPL break on improper errors #929

Merged
merged 2 commits into from
Oct 5, 2016
Merged

Fix REPL break on improper errors #929

merged 2 commits into from
Oct 5, 2016

Commits on Oct 5, 2016

  1. repl: remove double [Function] message 

    This line has been in here since Coco, and I can't see any reason why it
should be kept. Can you?
    @rhendric
    rhendric committed Oct 5, 2016
    Configuration menu
    Copy the full SHA
    c53f7ef View commit details
    Browse the repository at this point in the history

  2. repl: fix break on improper errors 

    This is an ugly hack, but it fixes the issue where the REPL will
sometimes stop responding to arrow keys after an error has been thrown
in user code. Turns out, this happens whenever a string (or anything
other than something with Error in its prototype hierarchy) is thrown.
The fix is to restore "raw mode" on the input TTY handle when this
situation is detected, by the time-honored method of turning it off and
on again.
    @rhendric
    rhendric committed Oct 5, 2016
    Configuration menu
    Copy the full SHA
    8dd66a9 View commit details
    Browse the repository at this point in the history