fix semiautovivification with slices #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| i = 0 | ||
| while i < tails.length when delete tails[i++].vivify | ||
| @head = Assign Chain(@head, tails.splice 0, i), that!, \= \|| | ||
| i = 0 |
There was a problem hiding this comment.
tails can contain multiple things in a row that aren't vivifications. The when guard makes i keep incrementing until it finds a vivification, at which point the loop body splices out everything in tails up to that vivification into the Assign. i needs to be reset back to 0 at that point because i elements have been removed from tails.
There was a problem hiding this comment.
Ah, duh. I use splice so much I can't even remember its arguments.. Sorry :/.
rhendric
force-pushed
the
fix/LiveScript-847
branch
from
062c519
to
78ef417
Compare
vendethiel
added a commit
that referenced
this pull request
Feb 18, 2016
fix semiautovivification with slices
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #847